Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add START pool #35

Merged
merged 1 commit into from
Aug 31, 2021
Merged

add START pool #35

merged 1 commit into from
Aug 31, 2021

Conversation

best-coder-NA
Copy link
Contributor

No description provided.

Copy link
Contributor

@SarjuHansaliya SarjuHansaliya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -60,6 +60,7 @@ export const STAKING_ADDRESSES = [
'0x10E5d5f598abb970F85456Ea59f0611D77E00168', // AVAX-ELE
'0xfd0824dF1E598D34C3495e1C2a339E2FA23Af40D', // AVAX-FRAX
'0x76Ad5c64Fe6B26b6aD9aaAA19eBa00e9eCa31FE1', // AVAX-FXS
'0x5105d9De003fB7d22979cd0cE167Ab919E60900A', // AVAX-START

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@best-coder-NA Any reason for the whitespace?

Copy link
Contributor

@HariSeldon23 HariSeldon23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small pedantic change to clean up whitespace. But we can add a linter to our process in the future @SarjuHansaliya - something for you to think about

@SarjuHansaliya
Copy link
Contributor

@HariSeldon23 I think this whitespace is to separate AVAX pools and PNG pools

@HariSeldon23
Copy link
Contributor

@HariSeldon23 I think this whitespace is to separate AVAX pools and PNG pools

Fair enough. Any idea why the Test is failing? I tried to rerun it and it still fails

@SarjuHansaliya
Copy link
Contributor

SarjuHansaliya commented Aug 31, 2021

Fair enough. Any idea why the Test is failing? I tried to rerun it and it still fails

yeah due to 0 APR

@bmino
Copy link
Contributor

bmino commented Aug 31, 2021

Yup the line breaks are intentional to separate pool "groups"

@bmino
Copy link
Contributor

bmino commented Aug 31, 2021

Addressing failed tests in #36

@bmino bmino merged commit 40e6256 into main Aug 31, 2021
@bmino bmino deleted the starterxyz branch August 31, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants